Skip to content

Conversation

@felarof99
Copy link
Contributor

  • fix: use source files for agent-sdk during development
  • fix: onboarding try it
  • fix: summarize current page
  • fix: ask browser os opens in agent mode

felarof99 and others added 4 commits January 21, 2026 18:20
Export src/index.ts directly in workspace mode so the server can import
without requiring a build step. publishConfig overrides exports to use
dist/ when publishing to npm.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude
Copy link

claude bot commented Jan 22, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@felarof99 felarof99 merged commit edfdaae into main Jan 22, 2026
6 of 7 checks passed
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 22, 2026

Greptile Summary

This PR consolidates BrowserOS interaction modes by defaulting to agent mode and simplifies the onboarding experience. The changes include:

  • Unified BrowserOS suggestions: Removed the conditional display logic that showed different icons and labels for chat vs agent mode. All suggestions now display "Ask BrowserOS:" with a Sparkles icon, while the underlying mode still differentiates behavior.
  • Default mode change: Changed the default suggestion mode from chat to agent in useBrowserOSSuggestions, aligning with the product direction to emphasize agent capabilities.
  • Simplified onboarding examples: Refactored the "Try it" button handlers in StepThree to use the simpler openSidePanelWithSearch messaging function instead of the complex runExample implementation that was removed. Updated the chat mode example query to "Summarize this page" (from "summarize today's news").
  • Development workflow improvement: Modified agent-sdk package.json to use source files during development while maintaining proper dist file references for published packages via publishConfig.

The changes maintain functional correctness while simplifying the codebase and improving the developer experience.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward refactorings and simplifications that maintain existing functionality. The mode logic still works correctly in the underlying code (as seen in NewTab.tsx), only the UI presentation was simplified. The onboarding refactor removes unused code without breaking functionality, and the package.json change is a valid development workflow improvement.
  • No files require special attention

Important Files Changed

Filename Overview
apps/agent/entrypoints/newtab/index/SearchSuggestions.tsx Simplified BrowserOS suggestion rendering by removing conditional chat/agent mode display logic, now always shows "Ask BrowserOS:" with Sparkles icon
apps/agent/entrypoints/newtab/index/lib/browserOSSuggestions/useBrowserOSSuggestions.ts Changed default mode from 'chat' to 'agent', removed commented-out agent mode suggestion
apps/agent/entrypoints/onboarding/steps/StepThree.tsx Refactored example functions to use simpler implementation with openSidePanelWithSearch, updated chat mode example query to "Summarize this page"
packages/agent-sdk/package.json Changed exports to point to source files during development, added publishConfig to use dist files when published

Sequence Diagram

sequenceDiagram
    participant User
    participant NewTab as NewTab Page
    participant Onboarding as Onboarding Step 3
    participant Suggestions as useBrowserOSSuggestions
    participant SidePanel as Side Panel
    participant Chrome as Chrome API

    Note over User,Chrome: New Tab Search Flow
    User->>NewTab: Types query in search
    NewTab->>Suggestions: Get BrowserOS suggestions
    Suggestions-->>NewTab: Returns [{mode: 'agent', message: query}]
    NewTab->>NewTab: Renders "Ask BrowserOS:" with Sparkles icon
    User->>NewTab: Selects suggestion
    NewTab->>SidePanel: openSidePanelWithSearch('open', {query, mode: 'agent'})
    SidePanel->>Chrome: Opens side panel with query

    Note over User,Chrome: Onboarding Try It Flow
    User->>Onboarding: Clicks "Try it" button (Chat Mode)
    Onboarding->>Chrome: chrome.tabs.create({url: 'https://news.google.com'})
    Chrome-->>Onboarding: New tab created
    Onboarding->>Onboarding: Wait 1500ms
    Onboarding->>SidePanel: openSidePanelWithSearch('open', {query: 'Summarize this page', mode: 'chat'})
    SidePanel->>Chrome: Opens side panel with query

    User->>Onboarding: Clicks "Try it" button (Agent Mode)
    Onboarding->>Chrome: chrome.tabs.create({url: 'about:blank'})
    Chrome-->>Onboarding: New tab created
    Onboarding->>Onboarding: Wait 500ms
    Onboarding->>SidePanel: openSidePanelWithSearch('open', {query: 'Navigate to amazon.com and order tide pods', mode: 'agent'})
    SidePanel->>Chrome: Opens side panel with query
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants